Bug 291917
| Summary: | Element::updateEffectiveTextDirectionIfNeeded recurses children multiple times | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Matt Woodrow <mattwoodrow> |
| Component: | Layout and Rendering | Assignee: | Matt Woodrow <mattwoodrow> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Matt Woodrow
updateEffectiveTextDirectionIfNeeded gets called (only) from insertedIntoAncestor, and does a full descendant walk to compute the direction if children are present.
insertedIntoAncestor should already be called for all descendants, so we shouldn't need to recurse both times.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/149808238>
Matt Woodrow
Pull request: https://github.com/WebKit/WebKit/pull/44389
EWS
Committed 294037@main (e31e3a25e7d4): <https://commits.webkit.org/294037@main>
Reviewed commits have been landed. Closing PR #44389 and removing active labels.