Bug 29191 – Add implementation of texImage2D that takes CanvasArray

• Component: DOM
• Status: RESOLVED FIXED

[Chris Marrin]

This is part of the spec not currently implemented

[Chris Marrin]

Created attachment 39447 [details]
Patch

[Oliver Hunt]

Comment on attachment 39447 [details]
Patch

> +        unsigned internalformat = args.at(2).toInt32(exec);
> +        unsigned width = args.at(3).toInt32(exec);
> +        unsigned height = args.at(4).toInt32(exec);
> +        unsigned border = args.at(5).toInt32(exec);
> +        unsigned format = args.at(6).toInt32(exec);
> +        unsigned type = args.at(7).toInt32(exec);
> +        CanvasArray* array = toCanvasArray(args.at(8));

You have no guarantee that this is actually a canvas array, so you need to do a type check and throw a typeerror or whatever.  Additionally all of these conversions can throw exceptions so *technically* there should be an exception check following each one.

[Chris Marrin]

Created attachment 39453 [details]
Replacement patch

[Oliver Hunt]

Comment on attachment 39453 [details]
Replacement patch

r=me

[Chris Marrin]

Sending        WebCore/ChangeLog
Sending        WebCore/bindings/js/JSCanvasRenderingContext3DCustom.cpp
Sending        WebCore/platform/graphics/mac/GraphicsContext3DMac.cpp
Transmitting file data ...
Committed revision 48310.