Bug 29179 – Geolocation LayoutTests should use an HTML template

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Steve Block]

Currently, most Geolocation LayoutTests use custom HTML wrappers. This is because the standard JS test HTML template includes js-test-post.js, which assumes that the test is synchronous, whereas most Geolocation tests are asynchronous.

We should use an HTML template for all Geolocation tests, setting a flag from JS to indicate when the test is asynchronous.

[Steve Block]

Created attachment 40303 [details]
Patch 1 for bug 29179

[Eric Seidel (no email)]

Comment on attachment 40303 [details]
Patch 1 for bug 29179

I think this looks OK. I think it would also be OK to add something like this to the main js-test-post file.

We'd talked about wrapping js-test-post's logic in a function (like finishTest()) and then js-test-post detecting that waitUntilDone() was set (might require adding API to layoutTestController) or using an explicit waitUntilDone() global call which called layoutTestController and also set an isAsynchronous = true flag, and then tests which were async needing to call a specific "notifyDone()" global call which would both call finishTest() and layoutTEstController.notifyDone().

[WebKit Commit Bot]

Comment on attachment 40303 [details]
Patch 1 for bug 29179

Clearing flags on attachment: 40303

Committed r48924: <http://trac.webkit.org/changeset/48924>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.