Bug 291770
| Summary: | Standardize on move arguments for ResourceRequest and ResourceResponse | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> |
| Component: | New Bugs | Assignee: | Brent Fulgham <bfulgham> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 291991 | ||
| Bug Blocks: | |||
Brent Fulgham
In Bug 291754 and Bug 291589 we added move parameters to various methods. This resulted in code duplication.
Instead, standardize on move parameters and explicitly perform copies at the relevant call sites. This helps us find missing move opportunities, and helps us see API where a lot of copying is needed.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/149577600>
Brent Fulgham
Pull request: https://github.com/WebKit/WebKit/pull/44275
EWS
Committed 294030@main (178f41b935d4): <https://commits.webkit.org/294030@main>
Reviewed commits have been landed. Closing PR #44275 and removing active labels.
Ben Schwartz
Reopened Bugzilla.
294030@main broke internal builds, tracking revert in https://bugs.webkit.org/show_bug.cgi?id=291991.
Brent Fulgham
Pull request: https://github.com/WebKit/WebKit/pull/44478
EWS
Committed 294079@main (b02503697e0b): <https://commits.webkit.org/294079@main>
Reviewed commits have been landed. Closing PR #44478 and removing active labels.