Summary: | execCommand('removeFormat') adds extra styles inside tables | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Julie Parent <jparent> | ||||
Component: | HTML Editing | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | hdn, michael.vm, rniwa | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Bug Depends on: | 43017 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Julie Parent
2009-09-10 17:17:26 PDT
Created attachment 71795 [details]
Patch
Comment on attachment 71795 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=71795&action=review > LayoutTests/editing/execCommand/remove-format-in-table-cell.html:8 > +Markup.description('This tests RemoveFormant command "hello". "hello" should be the immediate child of td below and there should be no style attribute.'); Nit: I'm not sure what 'This tests RemoveFormant command "hello".' means. Can you rewrite it? Something like: This tests that RemoveFormat doesn't add extra span tags when inside a table cell. Thanks for the review! (In reply to comment #2) > (From update of attachment 71795 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=71795&action=review > > > LayoutTests/editing/execCommand/remove-format-in-table-cell.html:8 > > +Markup.description('This tests RemoveFormant command "hello". "hello" should be the immediate child of td below and there should be no style attribute.'); > > Nit: I'm not sure what 'This tests RemoveFormant command "hello".' means. Can you rewrite it? Something like: > This tests that RemoveFormat doesn't add extra span tags when inside a table cell. This wasn't intended. Thanks for catching that. Will fix and land. Committed r70507: <http://trac.webkit.org/changeset/70507> |