Bug 291625
| Summary: | PAL_EXPORT not defined, WebKit_Internal can't be used as a clang module | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | adrian_taylor |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Enhancement | CC: | emw, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | All | ||
| OS: | macOS 15 | ||
adrian_taylor
Within Source/WebCore/PAL/pal/SessionID.h, PAL_EXPORT is used, despite a lack of
#include <pal/ExportMacros.h>
This is fine in normal WebKit builds, because -include config.h is provided on the command line, and config.h includes pal/ExportMacros.h.
However, if any header is added to WebKitInternal.h which transitively refers through to SessionID.h, the clang module does not build, because clang modules do not apply -include directives.
An easy fix here is just to add
#include <pal/ExportMacros.h>
to this file. I'll raise a PR to do that.
We might want to do something more systematic to ensure that config.h is strictly config.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
adrian_taylor
Pull request: https://github.com/WebKit/WebKit/pull/44145
Radar WebKit Bug Importer
<rdar://problem/149850888>
EWS
Committed 294724@main (4be5782bd026): <https://commits.webkit.org/294724@main>
Reviewed commits have been landed. Closing PR #44145 and removing active labels.