Bug 29152

Summary:

[v8] inline WebCore::v8String

Product:

WebKit

Reporter:

anton muhin <antonm>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
First pass	abarth: review+, commit-queue: commit-queue-
Hopefully right paths	none

anton muhin

Reported 2009-09-10 14:35:18 PDT

Inline WebCore::v8String---it's short enough.

Attachments
First pass (2.09 KB, patch) 2009-09-10 14:48 PDT, anton muhin	abarth: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Hopefully right paths (2.08 KB, patch) 2009-09-11 05:46 PDT, anton muhin	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

anton muhin

Comment 1 2009-09-10 14:48:55 PDT

Created attachment 39383 [details] First pass

WebKit Commit Bot

Comment 2 2009-09-10 15:49:36 PDT

Comment on attachment 39383 [details] First pass Rejecting patch 39383 from commit-queue. This patch will require manual commit. Patch https://bugs.webkit.org/attachment.cgi?id=39383 from bug 29152 failed to download and apply.

Eric Seidel (no email)

Comment 3 2009-09-10 16:15:16 PDT

Looks like this patch does not have full paths in it. Make sure you use svn-create-patch to create your patches. Although it's possible you're hitting bug 29112. can't find file to patch at input line 5 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |Index: bindings/v8/V8Binding.cpp |=================================================================== |--- bindings/v8/V8Binding.cpp (revision 48239) |+++ bindings/v8/V8Binding.cpp (working copy) -------------------------- No file to patch. Skipping patch. 1 out of 1 hunk ignored can't find file to patch at input line 5 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |Index: bindings/v8/V8Binding.h |=================================================================== |--- bindings/v8/V8Binding.h (revision 48239) |+++ bindings/v8/V8Binding.h (working copy) -------------------------- No file to patch. Skipping patch. 2 out of 2 hunks ignored

anton muhin

Comment 4 2009-09-11 05:46:02 PDT

Created attachment 39424 [details] Hopefully right paths

anton muhin

Comment 5 2009-09-11 05:49:21 PDT

(In reply to comment #3) > Looks like this patch does not have full paths in it. Make sure you use > svn-create-patch to create your patches. Although it's possible you're hitting > bug 29112. > > can't find file to patch at input line 5 > Perhaps you used the wrong -p or --strip option? > The text leading up to this was: > -------------------------- > |Index: bindings/v8/V8Binding.cpp > |=================================================================== > |--- bindings/v8/V8Binding.cpp (revision 48239) > |+++ bindings/v8/V8Binding.cpp (working copy) > -------------------------- > No file to patch. Skipping patch. > 1 out of 1 hunk ignored > can't find file to patch at input line 5 > Perhaps you used the wrong -p or --strip option? > The text leading up to this was: > -------------------------- > |Index: bindings/v8/V8Binding.h > |=================================================================== > |--- bindings/v8/V8Binding.h (revision 48239) > |+++ bindings/v8/V8Binding.h (working copy) > -------------------------- > No file to patch. Skipping patch. > 2 out of 2 hunks ignored Eric, I do use svn-create-patch (in Chromium tree, on MacOS, with WebKitTools, separate WebKit checkout) and that's exactly the way it creates patches. I raised this issue one, but currently don't have time to fix it myself. This patch was produced with plain svn diff and, hopefully, has correct paths.

WebKit Commit Bot

Comment 6 2009-09-11 07:47:39 PDT

Comment on attachment 39424 [details] Hopefully right paths Clearing flags on attachment: 39424 Committed r48301: <http://trac.webkit.org/changeset/48301>

WebKit Commit Bot

Comment 7 2009-09-11 07:47:46 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.