| Summary: | Added MathML toggle to build script | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Milowski <alex> | ||||||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | mrowe, vestbo | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Mac (Intel) | ||||||||||||
| OS: | OS X 10.5 | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 29158 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Alex Milowski
2009-09-10 13:03:36 PDT
Created attachment 39369 [details]
Patch to add toggle flag to build script
Comment on attachment 39369 [details] Patch to add toggle flag to build script Doesn't ENABLE_ need to be added to http://trac.webkit.org/browser/trunk/WebCore/Configurations/FeatureDefines.xcconfig too? I'm not sure what the rules are. Mark Rowe (bdash) would know. Comment on attachment 39369 [details]
Patch to add toggle flag to build script
Tabs in your ChangeLog will make this unlandable, r-
Created attachment 39371 [details]
Updated patch with tab removed
I have another patch that will use the ENABLE_MATHML. I don't see what an extra define that isn't used is going to hurt. When I submit the CSS patch and rendering patches, it will be added to the WebCore/Configurations/FeatureDefines.xconfig file. Comment on attachment 39371 [details]
Updated patch with tab removed
The variable and option declarations are in alphabetical order. The new variable and option should maintain that. I think it would be best for MathML to be disabled by default until the implementation is more complete and tested. Other than those minor issues, this change is fine.
Marking as r- as a revised patch will need to be posted before we can commit it.
Created attachment 39429 [details]
Updated patch with sorted order for additions
Comment on attachment 39429 [details]
Updated patch with sorted order for additions
LGTM
Comment on attachment 39429 [details]
Updated patch with sorted order for additions
r- per bdash's comment about also updating FeatureDefines.xcconfig
Created attachment 39612 [details]
Updated patch with FeatureDefines.xcconfig changes included
Comment on attachment 39612 [details]
Updated patch with FeatureDefines.xcconfig changes included
r=me
Landed in r48400 |