Bug 29138

Summary: Simplify popup menu handling
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: PlatformAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch aroben: review+

Anders Carlsson
Reported 2009-09-10 12:02:44 PDT
Currently, PopupMenu calls PopupMenuClient::hidePopup, when a popup menu needs to go away. The client method then hides the popup. The attached patch simplifies this so that calling PopupMenu::hide now hides the popup menu and then calls PopupMenuClient::popupDidHide.
Attachments
Patch (11.79 KB, patch)
2009-09-10 12:05 PDT, Anders Carlsson 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2009-09-10 12:05:58 PDT
Created attachment 39364 [details] Patch
Adam Roben (:aroben)
Comment 2 2009-09-10 13:35:56 PDT
Comment on attachment 39364 [details] Patch r=me
Eric Seidel (no email)
Comment 3 2009-09-18 13:21:25 PDT
Landed on Sept 14th as r48370.
Note You need to log in before you can comment on or make changes to this bug.