Bug 290911
| Summary: | filter-test-logs should signal failure when the scripts fail partway through | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Angelos Oikonomopoulos <angelos> |
| Component: | JavaScriptCore | Assignee: | Angelos Oikonomopoulos <angelos> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | aakash_jain, bfan2, gsnedders |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=290872 | ||
Angelos Oikonomopoulos
As it stands, when run-javascriptcore-tests or run-jsc-stress-tests throw an exception, filter-test-logs exits with 0 and doesn't report anything wrong. This results in a green bubble in buildbot.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Angelos Oikonomopoulos
Pull request: https://github.com/WebKit/WebKit/pull/43458
Angelos Oikonomopoulos
Note, an additional fix, to make things more robust, would be to change the buildbot command to ensure that we don't discard the exit code from run-javascriptcore-tests.
Angelos Oikonomopoulos
Closing as too brittle of a solution, see discussion in the PR.