Bug 29091 – commit-queue hangs if a builder has never built

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

commit-queue hangs if a builder has never built

buildbot.py was throwing exceptions when trying to parse the buildbot page if one of the builders had never built.  Fixed.

[Eric Seidel (no email)]

Created attachment 39276 [details]
Patch v1

[David Levin]

Comment on attachment 39276 [details]
Patch v1

r=me if there is a good answer to my question below.

> diff --git a/WebKitTools/Scripts/modules/buildbot.py b/WebKitTools/Scripts/modules/buildbot.py
> +        if not status_link:
> +            # We failed to find a link in the first cell, just give up.
> +            # This can happen if a builder is just-added, the first cell will just be "no build"
> +            return builder

Are other parts of the code robust to 'built_revision', 'is_green', 'build_url' not being in builder?

> diff --git a/WebKitTools/Scripts/modules/buildbot_unittest.py b/WebKitTools/Scripts/modules/buildbot_unittest.py
> +      <td align="center" class="Activity building">building<br />< 1 min</td>

&lt; 1 min ?

[Eric Seidel (no email)]

(In reply to comment #2)
> (From update of attachment 39276 [details])
> r=me if there is a good answer to my question below.
> 
> > diff --git a/WebKitTools/Scripts/modules/buildbot.py b/WebKitTools/Scripts/modules/buildbot.py
> > +        if not status_link:
> > +            # We failed to find a link in the first cell, just give up.
> > +            # This can happen if a builder is just-added, the first cell will just be "no build"
> > +            return builder
> 
> Are other parts of the code robust to 'built_revision', 'is_green', 'build_url'
> not being in builder?

Possibly not.  I'll check before landing and fix it to add is_green, etc if necessary.

> > diff --git a/WebKitTools/Scripts/modules/buildbot_unittest.py b/WebKitTools/Scripts/modules/buildbot_unittest.py
> > +      <td align="center" class="Activity building">building<br />< 1 min</td>
> 
> &lt; 1 min ?

I literally copy/pasted from the buildbot html source. :)  So I think I'll leave it as this "invalid" html for now. :)

[Eric Seidel (no email)]

Committed r48230: <http://trac.webkit.org/changeset/48230>