Bug 29085

Summary: Make PlatformWindow return something else than PlatformWidget
Product: WebKit Reporter: Kenneth Rohde Christiansen <kenneth>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: aroben, dglazkov, eric, fishd, gustavo, hausmann, hyatt, kevin.rogovin, laszlo.gombos, tonikitoo, ukai, vestbo, yael
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Make PlatformWindow return something else than PlatformWidget hausmann: review+

Kenneth Rohde Christiansen
Reported 2009-09-09 07:17:38 PDT
For the Qt port we would like to differentiate the return type of platformWidget and platformWindow, so that we can typedef that to something else. In particular we would like to use platformWindow to return a QWebPageClient. Since the platformWindow is per page, I would additionally like to rename it to platformChromeClient or platformPageClient. Any objections to such a change?
Attachments
Make PlatformWindow return something else than PlatformWidget (54.78 KB, patch)
2009-09-17 11:27 PDT, Kenneth Rohde Christiansen 		hausmann: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2009-09-09 07:59:59 PDT
You should talk to Hyatt about this change. He added the PlatformWindow stuff, I believe.
Dave Hyatt
Comment 2 2009-09-10 10:02:51 PDT
Seems fine.
Kenneth Rohde Christiansen
Comment 3 2009-09-17 11:27:48 PDT
Created attachment 39712 [details] Make PlatformWindow return something else than PlatformWidget
Simon Hausmann
Comment 4 2009-09-18 07:19:45 PDT
Comment on attachment 39712 [details] Make PlatformWindow return something else than PlatformWidget r=me
Simon Hausmann
Comment 5 2009-09-18 07:20:34 PDT
Eric, does this require any changes in Chromium? How can we synchronize the landing with the changes needed in Chromium?
Dimitri Glazkov (Google)
Comment 6 2009-09-18 07:42:09 PDT
Adding Darin (fishd).
Darin Fisher (:fishd, Google)
Comment 7 2009-09-18 09:20:50 PDT
This requires a small renaming change in the Chromium repository. Fortunately, we always return NULL for the platformWidget. So, the fixup on our end should just be about renaming the ChromeClient method.
Kenneth Rohde Christiansen
Comment 8 2009-09-18 09:28:26 PDT
(In reply to comment #7) > This requires a small renaming change in the Chromium repository. Fortunately, > we always return NULL for the platformWidget. So, the fixup on our end should > just be about renaming the ChromeClient method. That said, is it OK with you that I commit this right away?
Darin Fisher (:fishd, Google)
Comment 9 2009-09-18 10:31:36 PDT
We'll be able to cope. Thanks!
Kenneth Rohde Christiansen
Comment 10 2009-09-18 10:35:06 PDT
Thansk! Landed in 48511
Note You need to log in before you can comment on or make changes to this bug.