Bug 29066

Summary: Remove WTF_PLATFORM_FORCE_PACK as it is no longer used
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
proposed patch. darin: review+, eric: commit-queue+

Laszlo Gombos
Reported 2009-09-08 19:14:08 PDT
svn blame pointed me to to this 2 years old commit. http://trac.webkit.org/changeset/25321 I did a full search for FORCE_PACK in the source tree and all the references are removed from WebKit. ARM detection rules are already compex enough, we do not need a configuration option that is no longer used.
Attachments
proposed patch. (1.11 KB, patch)
2009-09-08 19:45 PDT, Laszlo Gombos 		darin: review+
eric: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2009-09-08 19:45:30 PDT
Created attachment 39243 [details] proposed patch.
Eric Seidel (no email)
Comment 2 2009-09-09 09:32:50 PDT
Comment on attachment 39243 [details] proposed patch. Rejecting patch 39243 from commit-queue. laszlo.1.gombos@nokia.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py.
Eric Seidel (no email)
Comment 3 2009-09-09 09:38:50 PDT
Comment on attachment 39243 [details] proposed patch. Seems laszlo needs to add himself to committers.py. But I'm happy to set cq+ on this patch.
Laszlo Gombos
Comment 4 2009-09-09 10:01:23 PDT
(In reply to comment #3) > (From update of attachment 39243 [details]) > Seems laszlo needs to add himself to committers.py. But I'm happy to set cq+ > on this patch. Eric, I think I added myself to the list yesterday - see http://trac.webkit.org/changeset/48159 I'm happy to commit as well, if needed.
Eric Seidel (no email)
Comment 5 2009-09-09 10:58:03 PDT
http://trac.webkit.org/changeset/48216 The commit-queue is undergoing some minor surgery at the moment. :) Bear with me...
Note You need to log in before you can comment on or make changes to this bug.