Bug 29066 - Remove WTF_PLATFORM_FORCE_PACK as it is no longer used
Summary: Remove WTF_PLATFORM_FORCE_PACK as it is no longer used
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-08 19:14 PDT by Laszlo Gombos
Modified: 2009-09-09 10:58 PDT (History)
1 user (show)

See Also:


Attachments
proposed patch. (1.11 KB, patch)
2009-09-08 19:45 PDT, Laszlo Gombos
darin: review+
eric: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2009-09-08 19:14:08 PDT
svn blame pointed me to to this 2 years old commit. http://trac.webkit.org/changeset/25321

I did a full search for FORCE_PACK in the source tree and all the references are removed from WebKit.

ARM detection rules are already compex enough, we do not need a configuration option that is no longer used.
Comment 1 Laszlo Gombos 2009-09-08 19:45:30 PDT
Created attachment 39243 [details]
proposed patch.
Comment 2 Eric Seidel (no email) 2009-09-09 09:32:50 PDT
Comment on attachment 39243 [details]
proposed patch.

Rejecting patch 39243 from commit-queue.

laszlo.1.gombos@nokia.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py.
Comment 3 Eric Seidel (no email) 2009-09-09 09:38:50 PDT
Comment on attachment 39243 [details]
proposed patch.

Seems laszlo needs to add himself to committers.py.  But I'm happy to set cq+ on this patch.
Comment 4 Laszlo Gombos 2009-09-09 10:01:23 PDT
(In reply to comment #3)
> (From update of attachment 39243 [details])
> Seems laszlo needs to add himself to committers.py.  But I'm happy to set cq+
> on this patch.

Eric, I think I added myself to the list yesterday - see http://trac.webkit.org/changeset/48159

I'm happy to commit as well, if needed.
Comment 5 Eric Seidel (no email) 2009-09-09 10:58:03 PDT
http://trac.webkit.org/changeset/48216

The commit-queue is undergoing some minor surgery at the moment. :)  Bear with me...