Summary: | [Qt] make RenderStyle.h compile in winscw compiler. | ||
---|---|---|---|
Product: | WebKit | Reporter: | Yongjun Zhang <yongjun.zhang> |
Component: | Tools / Tests | Assignee: | Yongjun Zhang <yongjun.zhang> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | commit-queue, hausmann, koshuin, laszlo.gombos, webkit.review.bot |
Priority: | P2 | Keywords: | Qt |
Version: | 528+ (Nightly build) | ||
Hardware: | S60 Emulator | ||
OS: | S60 3rd edition | ||
Bug Depends on: | |||
Bug Blocks: | 27065 | ||
Attachments: |
Description
Yongjun Zhang
2009-09-08 13:43:27 PDT
Created attachment 39217 [details]
Change compareEqual to a macro in Winscw compiler to get around "illegal operand" error when compareEqual is defined as template.
Comment on attachment 39217 [details]
Change compareEqual to a macro in Winscw compiler to get around "illegal operand" error when compareEqual is defined as template.
There needs to be a comment next to the macro definition as to why it exists.
Also, could you paste the error in the bug? Are we sure this is the best solution? Do we have a bug filed with the winscw compiler? If so, can we link to it?
Please use the keyword 'Qt' for bugs related to QtWebKit. The component 'WebKit Qt' is for QtWebKit API issues only. This appears to be one of the few remaining WINSCW issues. Any update on this about the error message, etc.? (See Eric's comment) There was a bug reported against this in Winscw compiler bugzilla: https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=10447 Created attachment 45686 [details]
add link to winscw compiler bug as suggested by Erik.
style-queue ran check-webkit-style on attachment 45686 [details] without any errors.
Comment on attachment 45686 [details]
add link to winscw compiler bug as suggested by Erik.
Looks good to me, r+;
At commit, it would be useful to add a comment right by the macro in RenderStyle.h as well, as Eric suggested.
Comment on attachment 45686 [details] add link to winscw compiler bug as suggested by Erik. Clearing flags on attachment: 45686 Committed r52733: <http://trac.webkit.org/changeset/52733> All reviewed patches have been landed. Closing bug. |