Bug 29043

Summary:

shared-worker-exception.html needs to pause to let console messages get written out

Product:

WebKit

Reporter:

Andrew Wilson <atwilson>

Component:

WebCore JavaScript

Assignee:

Andrew Wilson <atwilson>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
proposed patch	mjs: review+, mjs: commit-queue-

Andrew Wilson

Reported 2009-09-08 11:46:18 PDT

The test is slightly flaky because sometimes the console message doesn't get written out until the subsequent test runs, leading to two broken tests.

Attachments
proposed patch (1.25 KB, patch) 2009-09-08 17:28 PDT, Andrew Wilson	mjs: review+ mjs: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Andrew Wilson

Comment 1 2009-09-08 17:28:18 PDT

Created attachment 39234 [details] proposed patch Updated layout test to pause 10ms before shutting down the test to let unhandled worker exceptions get written to the console.

Maciej Stachowiak

Comment 2 2009-09-08 18:18:06 PDT

Comment on attachment 39234 [details] proposed patch r=me Try using a 0-delay timer - from IRC discussion, I believe it will achieve the desired goal here.

Andrew Wilson

Comment 3 2009-09-08 18:46:03 PDT

Committed as r48196 (with 0-msec timer)

Note You need to log in before you can comment on or make changes to this bug.