Bug 29040

Summary: Geolocation does not correctly handle reentrant calls from callbacks
Product: WebKit Reporter: Steve Block <steveblock>
Component: WebCore Misc.Assignee: Steve Block <steveblock>
Status: RESOLVED FIXED    
Severity: Normal CC: andreip, benm, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 28305    
Bug Blocks: 27944    
Attachments:
Description Flags
Patch 1 for bug 29040 darin: review+

Steve Block
Reported 2009-09-08 10:47:42 PDT
When Geolocation callbacks are made, currently running requests (oneShots and watchers) are stopped immediately afterwards. This means that if reentrant calls to Geolocation methods are made from the callbacks, any new requests started by those reentrant calls are immediately stopped.
Attachments
Patch 1 for bug 29040 (13.71 KB, patch)
2009-09-09 10:18 PDT, Steve Block 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2009-09-08 10:51:00 PDT
The tests for Bug 27944 require that this bug is fixed.
Steve Block
Comment 2 2009-09-09 10:18:06 PDT
Created attachment 39275 [details] Patch 1 for bug 29040 Fixes bug and adds LayoutTests.
Ben Murdoch
Comment 3 2009-09-10 10:17:18 PDT
Landed as r48258.
Note You need to log in before you can comment on or make changes to this bug.