Bug 290216
| Summary: | [GTK][WPE][Skia] Stop using finishAcceleratedRenderingAndCreateFence & friends in ImageBuffer | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Nikolas Zimmermann <zimmermann> |
| Component: | WPE WebKit | Assignee: | Nikolas Zimmermann <zimmermann> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 289456 | ||
| Bug Blocks: | 290283, 290284 | ||
Nikolas Zimmermann
ImageBuffer::sinkIntoImageBufferForCrossThreadTransfer() and ImageBuffer::sinkIntoImageBufferAfterCrossThreadTransfer() make use of finishAcceleratedRenderingAndCreateFence / waitForAcceleratedRenderingFenceCompletion / copyAcceleratedImageBufferBorrowingBackendRenderTarget.
These functions and the Skia-specific DisplayList code still use these methods. After switching from using DisplayList to SkPicture in SkiaPaintingEngine, we can purge the whole fencing logic from ImageBuffer/NativeImage & friends.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Nikolas Zimmermann
Pull request: https://github.com/WebKit/WebKit/pull/42843
EWS
Committed 292699@main (f18fd5a7e638): <https://commits.webkit.org/292699@main>
Reviewed commits have been landed. Closing PR #42843 and removing active labels.