Bug 29011

Summary: Build fix when USE(LOCKFREE_THREADSAFESHARED) is not defined
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ben, eric, koshuin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Other   
Bug Depends on:    
Bug Blocks: 27065    
Attachments:
Description Flags
proposed patch. none

Laszlo Gombos
Reported 2009-09-07 08:11:18 PDT
Some WebKit ports (e.g. Symbian QtWebKit port) does not (yet) define atomicIncrement and atomicDecrement functions. This is a "supported" configuration and the USE(LOCKFREE_THREADSAFESHARED) is used to determine if atomicIncrement and atomicDecrement functions are available. ChangeSet http://trac.webkit.org/changeset/47845 introduced a change in Threading.h which would require to implement atomicIncrement and atomicDecrement functions for all ports. Guarding some of the changes in Threading.h with USE(LOCKFREE_THREADSAFESHARED) would fix this problem (and would fix the Symbian QtWebKit build). Patch will follow.
Attachments
proposed patch. (1.11 KB, patch)
2009-09-07 08:17 PDT, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2009-09-07 08:17:40 PDT
Created attachment 39148 [details] proposed patch.
Simon Hausmann
Comment 2 2009-09-07 09:40:17 PDT
Comment on attachment 39148 [details] proposed patch. r=me
Mark Rowe (bdash)
Comment 3 2009-09-08 03:29:04 PDT
*** Bug 29028 has been marked as a duplicate of this bug. ***
Eric Seidel (no email)
Comment 4 2009-09-08 08:23:45 PDT
Comment on attachment 39148 [details] proposed patch. Exception: Unknown committer: laszlo.1.gombos@nokia.com If you're a committer, please make sure you're in LayoutTests/WebKitTools/Scripts/modules/committers.py
Laszlo Gombos
Comment 5 2009-09-08 09:14:16 PDT
Comment on attachment 39148 [details] proposed patch. Thanks Eric ! Added myself to list of committers -- http://trac.webkit.org/changeset/48159. Let's try the commit-queue again.
Eric Seidel (no email)
Comment 6 2009-09-08 10:15:09 PDT
Comment on attachment 39148 [details] proposed patch. Clearing flags on attachment: 39148 Committed r48161: <http://trac.webkit.org/changeset/48161>
Eric Seidel (no email)
Comment 7 2009-09-08 10:15:15 PDT
All reviewed patches have been landed. Closing bug.
Mark Rowe (bdash)
Comment 8 2009-09-10 15:29:01 PDT
*** Bug 29149 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.