Bug 29009

Summary:

[V8] Cleanup document/frame null-checking in V8DOMWindowCustom.cpp

Product:

WebKit

Reporter:

Mads Ager <ager>

Component:

WebCore JavaScript

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Be consistent in document and frame null checking.	none

Description Mads Ager 2009-09-07 07:01:08 PDT

The document and frame null checking in V8DOMWindowCustom.cpp is inconsistent and a couple of checks are missing.

We should use the DOMWindow::document accessor and let that one null check the frame.  We should always null check the result of that accessor.  canAccessFrame returns false for a null frame - we should use that fact consistently.

Comment 1 Mads Ager 2009-09-07 07:24:24 PDT

Created attachment 39145 [details]
Be consistent in document and frame null checking.

Comment 2 Eric Seidel (no email) 2009-09-07 07:49:12 PDT

Comment on attachment 39145 [details]
Be consistent in document and frame null checking.

Clearing flags on attachment: 39145

Committed r48114: <http://trac.webkit.org/changeset/48114>

Comment 3 Eric Seidel (no email) 2009-09-07 07:49:16 PDT

All reviewed patches have been landed.  Closing bug.