Bug 29009

Summary: [V8] Cleanup document/frame null-checking in V8DOMWindowCustom.cpp
Product: WebKit Reporter: Mads Ager <ager>
Component: WebCore JavaScriptAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Be consistent in document and frame null checking. none

Mads Ager
Reported 2009-09-07 07:01:08 PDT
The document and frame null checking in V8DOMWindowCustom.cpp is inconsistent and a couple of checks are missing. We should use the DOMWindow::document accessor and let that one null check the frame. We should always null check the result of that accessor. canAccessFrame returns false for a null frame - we should use that fact consistently.
Attachments
Be consistent in document and frame null checking. (5.49 KB, patch)
2009-09-07 07:24 PDT, Mads Ager 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mads Ager
Comment 1 2009-09-07 07:24:24 PDT
Created attachment 39145 [details] Be consistent in document and frame null checking.
Eric Seidel (no email)
Comment 2 2009-09-07 07:49:12 PDT
Comment on attachment 39145 [details] Be consistent in document and frame null checking. Clearing flags on attachment: 39145 Committed r48114: <http://trac.webkit.org/changeset/48114>
Eric Seidel (no email)
Comment 3 2009-09-07 07:49:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.