Bug 29003

Summary:

Detect mixed content

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, bweinstein, emacemac7, eric, fishd, levin, mjs, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
mixed-content patch	none
mixed-content patch	sam: review+, abarth: commit-queue-

Adam Barth

Reported 2009-09-06 21:14:26 PDT

Now that we have the client callbacks, we should actually detect some mixed content (HTTP content loading into an HTTPS frame)! In this bug, my plan is to just get some basic detection in the tree. We can make sure we get all the corner cases right in follow-up bugs.

Attachments
mixed-content patch (49.20 KB, patch) 2009-09-06 21:15 PDT, Adam Barth	no flags	Details Formatted Diff Diff
mixed-content patch (48.89 KB, patch) 2009-09-06 21:20 PDT, Adam Barth	sam: review+ abarth: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2009-09-06 21:15:57 PDT

Created attachment 39131 [details] mixed-content patch --- 48 files changed, 708 insertions(+), 1 deletions(-)

Adam Barth

Comment 2 2009-09-06 21:20:02 PDT

Created attachment 39132 [details] mixed-content patch --- 48 files changed, 707 insertions(+), 1 deletions(-)

Sam Weinig

Comment 3 2009-09-10 21:11:15 PDT

Comment on attachment 39132 [details] mixed-content patch Looks great. r=me

Adam Barth

Comment 4 2009-09-10 21:57:54 PDT

Comment on attachment 39132 [details] mixed-content patch Rejecting patch 39132 from commit-queue. This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--exit-after-n-failures=1'] failed with exit code 1

Adam Barth

Comment 5 2009-09-10 22:48:16 PDT

Committed r48284: <http://trac.webkit.org/changeset/48284>

Brian Weinstein

Comment 6 2009-09-11 14:55:38 PDT

These tests are failing on Windows, any idea what is going on?

Adam Barth

Comment 7 2009-09-11 15:06:45 PDT

Thanks for letting me know. I'll investigate when I get home.

Brian Weinstein

Comment 8 2009-09-11 16:55:26 PDT

https://bugs.webkit.org/show_bug.cgi?id=29213 is tracking the test failures on Windows.

Note You need to log in before you can comment on or make changes to this bug.