Bug 28993

Summary: [Qt] Remove Qt v4.6 check from the prefetchDNS implementation
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed patch. none

Laszlo Gombos
Reported 2009-09-04 17:08:11 PDT
Functionality behind r47425 (http://trac.webkit.org/changeset/47425) is guarded with Qt v4.6 build check. Typically we do not use a build time Qt version check for newly introduced QtWebKit functionality. The usage of Qt version check is should be restricted to guard QtWebKit functionality that depends on a Qt functionality that is not available in all Qt versions. In this particular case the functionality introduced by r47425 builds and functions just fine using Qt v4.5. In addition removing the build flag also gets rid of a build warning (from moc).
Attachments
proposed patch. (1.76 KB, patch)
2009-09-04 17:12 PDT, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2009-09-04 17:12:32 PDT
Created attachment 39104 [details] proposed patch.
Eric Seidel (no email)
Comment 2 2009-09-05 16:29:07 PDT
Comment on attachment 39104 [details] proposed patch. OK. rs=me. I can't remember if you're a committer. Assuming not. cq+
Eric Seidel (no email)
Comment 3 2009-09-05 16:40:29 PDT
Comment on attachment 39104 [details] proposed patch. Rejecting patch 39104 from commit-queue. This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1
Laszlo Gombos
Comment 4 2009-09-05 17:13:35 PDT
(In reply to comment #3) > (From update of attachment 39104 [details]) > Rejecting patch 39104 from commit-queue. This patch will require manual > commit. > > ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', > '--exit-after-n-failures=1'] failed with exit code 1 Eric, I can/will commit, thanks for the review.
Eric Seidel (no email)
Comment 5 2009-09-06 02:02:27 PDT
Comment on attachment 39104 [details] proposed patch. Another victim of bug 28845. media/video-source-error.html -> timed out
Eric Seidel (no email)
Comment 6 2009-09-06 02:09:33 PDT
Comment on attachment 39104 [details] proposed patch. Rejecting patch 39104 from commit-queue. This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1
Laszlo Gombos
Comment 7 2009-09-06 05:39:37 PDT
(In reply to comment #6) > (From update of attachment 39104 [details]) > Rejecting patch 39104 from commit-queue. This patch will require manual > commit. > > ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', > '--exit-after-n-failures=1'] failed with exit code 1 Committed - http://trac.webkit.org/changeset/48100
Eric Seidel (no email)
Comment 8 2009-09-07 00:08:48 PDT
Thank you. The commit-queue is kinda paralyzed by bug 28845 at the moment. This hit it *again* when trying to land.
Eric Seidel (no email)
Comment 9 2009-09-07 00:10:17 PDT
Actually it hit a different test the final time, same bug though: compositing/geometry/abs-position-inside-opacity.html -> timed out
Note You need to log in before you can comment on or make changes to this bug.