Summary: | Eliminate the remote user stylesheet loader on Mac/Qt | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dave Hyatt <hyatt> | ||||
Component: | New Bugs | Assignee: | Dave Hyatt <hyatt> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | tonikitoo | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Dave Hyatt
2009-09-04 13:59:41 PDT
Created attachment 39088 [details]
Patch
Comment on attachment 39088 [details] Patch > void Page::userStyleSheetLocationChanged() > { > -#if !FRAME_LOADS_USER_STYLESHEET > // FIXME: We should provide a way to load other types of URLs than just > - // file: (e.g., http:, data:). > - if (m_settings->userStyleSheetLocation().isLocalFile()) > - m_userStyleSheetPath = m_settings->userStyleSheetLocation().fileSystemPath(); > + // file: (e.g., http:). I guess you don't agree with this FIXME at all. Maybe you should remove it? You should remove UserStyleSheetLoader from the Qt project files. You should explain in your ChangeLog how you made the decision that it's OK to do this. Do we have regression tests for the user stylesheet code? r=me |