Bug 28984

Summary: Eliminate the remote user stylesheet loader on Mac/Qt
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: New BugsAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch aroben: review+

Dave Hyatt
Reported 2009-09-04 13:59:41 PDT
Remove the separate code path on Mac/Qt for user stylesheet loading. Make sure the cross-platform code path used by everyone else gets data URL support to match Mac/Qt, and then switch everyone over to it.
Attachments
Patch (20.49 KB, patch)
2009-09-04 14:01 PDT, Dave Hyatt 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2009-09-04 14:01:15 PDT
Created attachment 39088 [details] Patch
Adam Roben (:aroben)
Comment 2 2009-09-04 14:04:24 PDT
Comment on attachment 39088 [details] Patch > void Page::userStyleSheetLocationChanged() > { > -#if !FRAME_LOADS_USER_STYLESHEET > // FIXME: We should provide a way to load other types of URLs than just > - // file: (e.g., http:, data:). > - if (m_settings->userStyleSheetLocation().isLocalFile()) > - m_userStyleSheetPath = m_settings->userStyleSheetLocation().fileSystemPath(); > + // file: (e.g., http:). I guess you don't agree with this FIXME at all. Maybe you should remove it? You should remove UserStyleSheetLoader from the Qt project files. You should explain in your ChangeLog how you made the decision that it's OK to do this. Do we have regression tests for the user stylesheet code? r=me
Dave Hyatt
Comment 3 2009-09-04 14:33:35 PDT
Fixed in r48075.
Note You need to log in before you can comment on or make changes to this bug.