Bug 28966

Summary:

[HTML5][Forms] <input type=color> simple implementation

Product:

WebKit

Reporter:

Kent Tamura <tkent>

Component:

Forms

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

adele, darin, eric, hyatt, michelangelo, pkasting

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

URL:

http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#color-state

Bug Depends on:

Bug Blocks:

19264, 29358

Attachments:

Description	Flags
Proposed patch	none

Kent Tamura

Reported 2009-09-04 00:52:19 PDT

Implement type=color as a text field without a fancy color picker, and validation support for type=color.

Attachments
Proposed patch (16.63 KB, patch) 2009-09-04 01:00 PDT, Kent Tamura	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Kent Tamura

Comment 1 2009-09-04 01:00:18 PDT

Created attachment 39044 [details] Proposed patch

Eric Seidel (no email)

Comment 2 2009-09-04 01:21:50 PDT

Comment on attachment 39044 [details] Proposed patch I guess this is an OK start. On Mac we'll want to use the NSColorWell I figure. I don't see why it's useful to ever have a text box for color picking.

Eric Seidel (no email)

Comment 3 2009-09-04 01:32:58 PDT

Comment on attachment 39044 [details] Proposed patch Clearing flags on attachment: 39044 Committed r48043: <http://trac.webkit.org/changeset/48043>

Eric Seidel (no email)

Comment 4 2009-09-04 01:33:02 PDT

All reviewed patches have been landed. Closing bug.

Kent Tamura

Comment 5 2009-09-04 02:11:17 PDT

(In reply to comment #2) > (From update of attachment 39044 [details]) > I guess this is an OK start. On Mac we'll want to use the NSColorWell I > figure. I don't see why it's useful to ever have a text box for color picking. Definitely. We'll work on the UI. Thank you very much for the quick review.

Note You need to log in before you can comment on or make changes to this bug.