Bug 28966

Summary: [HTML5][Forms] <input type=color> simple implementation
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: adele, darin, eric, hyatt, michelangelo, pkasting
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#color-state
Bug Depends on:    
Bug Blocks: 19264, 29358    
Attachments:
Description Flags
Proposed patch none

Description Kent Tamura 2009-09-04 00:52:19 PDT
Implement type=color as a text field without a fancy color picker, and validation support for type=color.
Comment 1 Kent Tamura 2009-09-04 01:00:18 PDT
Created attachment 39044 [details]
Proposed patch
Comment 2 Eric Seidel (no email) 2009-09-04 01:21:50 PDT
Comment on attachment 39044 [details]
Proposed patch

I guess this is an OK start.  On Mac we'll want to use the NSColorWell I figure.  I don't see why it's useful to ever have a text box for color picking.
Comment 3 Eric Seidel (no email) 2009-09-04 01:32:58 PDT
Comment on attachment 39044 [details]
Proposed patch

Clearing flags on attachment: 39044

Committed r48043: <http://trac.webkit.org/changeset/48043>
Comment 4 Eric Seidel (no email) 2009-09-04 01:33:02 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Kent Tamura 2009-09-04 02:11:17 PDT
(In reply to comment #2)
> (From update of attachment 39044 [details])
> I guess this is an OK start.  On Mac we'll want to use the NSColorWell I
> figure.  I don't see why it's useful to ever have a text box for color picking.

Definitely.  We'll work on the UI.
Thank you very much for the quick review.