Bug 28965

Summary:

[V8] Crash when updating document cache

Product:

WebKit

Reporter:

Mads Ager <ager>

Component:

WebCore JavaScript

Assignee:

David Levin <levin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, levin

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Bail out if context initialization in updateDocument fails.	levin: review+, levin: commit-queue-

Mads Ager

Reported 2009-09-04 00:37:45 PDT

In some situations initialization of the JavaScript context can fail. When that happens we cannot update the document cache. This makes http/tests/security/javascriptURL/javascriptURL-in-new-iframe.html crash.

Attachments
Bail out if context initialization in updateDocument fails. (1.19 KB, patch) 2009-09-04 00:47 PDT, Mads Ager	levin: review+ levin: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Mads Ager

Comment 1 2009-09-04 00:47:01 PDT

Created attachment 39043 [details] Bail out if context initialization in updateDocument fails.

David Levin

Comment 2 2009-09-04 01:00:41 PDT

Comment on attachment 39043 [details] Bail out if context initialization in updateDocument fails. The changelog should mention that this is tested by -- and name the test that you mentioned in the bug.

David Levin

Comment 3 2009-09-04 01:01:38 PDT

I'll fix the change log and land this.

David Levin

Comment 4 2009-09-04 01:09:19 PDT

Committed as http://trac.webkit.org/changeset/48042

Note You need to log in before you can comment on or make changes to this bug.