Bug 28961

Summary: [Qt] Fix tst_QWebPage::database autotest failure
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed patch. none

Laszlo Gombos
Reported 2009-09-03 19:31:04 PDT
FAIL! : tst_QWebPage::database() Compared values are not the same Actual (s1.toString()): Expected (QString("This is a test for local storage")): This is a test for local storage Loc: [WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(426)]
Attachments
proposed patch. (1.41 KB, patch)
2009-09-03 19:54 PDT, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2009-09-03 19:54:23 PDT
Created attachment 39034 [details] proposed patch. Test case broke after http://trac.webkit.org/changeset/47283 which disabled localStorage by default. Enable all the features that are tested explicitly to avoid this problem in the future.
Eric Seidel (no email)
Comment 2 2009-09-04 00:15:24 PDT
Comment on attachment 39034 [details] proposed patch. LGTM.
Eric Seidel (no email)
Comment 3 2009-09-04 00:24:26 PDT
Comment on attachment 39034 [details] proposed patch. Rejecting patch 39034 from commit-queue. This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1
Eric Seidel (no email)
Comment 4 2009-09-04 00:42:12 PDT
Comment on attachment 39034 [details] proposed patch. Yet another victim of bug 28845! media/video-source-error.html -> crashed
Eric Seidel (no email)
Comment 5 2009-09-04 00:50:43 PDT
Comment on attachment 39034 [details] proposed patch. Clearing flags on attachment: 39034 Committed r48041: <http://trac.webkit.org/changeset/48041>
Eric Seidel (no email)
Comment 6 2009-09-04 00:50:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.