Bug 289456
| Summary: | [GTK][WPE][Skia] Use SkPicture(Recorder) instead of DisplayList(Recorder) for paint command recording in multi-threaded rendering mode | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Nikolas Zimmermann <zimmermann> |
| Component: | WPE WebKit | Assignee: | Nikolas Zimmermann <zimmermann> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 290216, 290283, 290284, 290614 | ||
Nikolas Zimmermann
DisplayList are not safe to be replayed at any time in the future. While DisplayList::ResourceHeap protects referenced WebCore objects from destruction, it cannot protect us from modifications. While we haven't observed practical problems in our usage scenarios in WPE yet, it is error-prone and holds back optimizations / security protections that blocks Kimmos current work.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Nikolas Zimmermann
Pull request: https://github.com/WebKit/WebKit/pull/42185
EWS
Committed 292639@main (fca89822979c): <https://commits.webkit.org/292639@main>
Reviewed commits have been landed. Closing PR #42185 and removing active labels.