Bug 28927

Summary:

Fix DumpRenderTree build from clean tree on Tiger

Product:

WebKit

Reporter:

Cameron McCormack (:heycam) <heycam>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
Patch v1	none

Cameron McCormack (:heycam)

Reported 2009-09-02 17:13:43 PDT

A mkdir call is missing from a DumpRenderTree makefile that causes the DRT build to fail on Tiger.

Attachments
Patch v1 (1.88 KB, patch) 2009-09-02 17:16 PDT, Cameron McCormack (:heycam)	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Cameron McCormack (:heycam)

Comment 1 2009-09-02 17:16:51 PDT

Created attachment 38949 [details] Patch v1

Darin Adler

Comment 2 2009-09-02 17:21:45 PDT

Comment on attachment 38949 [details] Patch v1 Why make the dirname change? r=me

Cameron McCormack (:heycam)

Comment 3 2009-09-02 17:26:59 PDT

(In reply to comment #2) > Why make the dirname change? Was just factoring out the directory name determination. I guess I could have left the dirname call in the WRAPPER_DIR assignment.

Eric Seidel (no email)

Comment 4 2009-09-08 11:02:58 PDT

Comment on attachment 38949 [details] Patch v1 Clearing flags on attachment: 38949 Committed r48170: <http://trac.webkit.org/changeset/48170>

Eric Seidel (no email)

Comment 5 2009-09-08 11:03:02 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.