Bug 289151
| Summary: | On macOS, combine the two suppress-HDR observers into one | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Gerald Squelart <g_squelart> |
| Component: | Media | Assignee: | Gerald Squelart <g_squelart> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 283314, 288690 | ||
| Bug Blocks: | |||
Gerald Squelart
For NSApplicationShouldBeginSuppressingHighDynamicRangeContentNotification and NSApplicationShouldEndSuppressingHighDynamicRangeContentNotification:
1. https://bugs.webkit.org/show_bug.cgi?id=283314 added observers in UIProcess/mac/WebViewImpl.mm, which updates all CALayers in the process.
2. https://bugs.webkit.org/show_bug.cgi?id=288690 added observers in UIProcess/Cocoa/WebProcessPoolCocoa.mm, which sends messages to all processes, going to WebPages.
We should combine these two into one.
I'm thinking to going with the 1st, it removes all the WebProcess-specific code. Also, it more closely matches the iOS side, which is also in a WebView and just notifies the attached WebPage.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/146236713>
Gerald Squelart
Pull request: https://github.com/WebKit/WebKit/pull/41908
EWS
Committed 292115@main (c0f7f82bf6f1): <https://commits.webkit.org/292115@main>
Reviewed commits have been landed. Closing PR #41908 and removing active labels.