WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
289151
On macOS, combine the two suppress-HDR observers into one
https://bugs.webkit.org/show_bug.cgi?id=289151
Summary
On macOS, combine the two suppress-HDR observers into one
Gerald Squelart
Reported
2025-03-05 00:52:51 PST
For NSApplicationShouldBeginSuppressingHighDynamicRangeContentNotification and NSApplicationShouldEndSuppressingHighDynamicRangeContentNotification: 1.
https://bugs.webkit.org/show_bug.cgi?id=283314
added observers in UIProcess/mac/WebViewImpl.mm, which updates all CALayers in the process. 2.
https://bugs.webkit.org/show_bug.cgi?id=288690
added observers in UIProcess/Cocoa/WebProcessPoolCocoa.mm, which sends messages to all processes, going to WebPages. We should combine these two into one. I'm thinking to going with the 1st, it removes all the WebProcess-specific code. Also, it more closely matches the iOS side, which is also in a WebView and just notifies the attached WebPage.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2025-03-05 00:53:11 PST
<
rdar://problem/146236713
>
Gerald Squelart
Comment 2
2025-03-05 00:59:33 PST
Pull request:
https://github.com/WebKit/WebKit/pull/41908
EWS
Comment 3
2025-03-13 14:00:43 PDT
Committed
292115@main
(c0f7f82bf6f1): <
https://commits.webkit.org/292115@main
> Reviewed commits have been landed. Closing PR #41908 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug