Bug 288970
| Summary: | [Win] Fix ISO_MALLOC export macros on Windows | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ian Grunert <ian.grunert> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | Hironori.Fujii, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | PC | ||
| OS: | Windows 11 | ||
| Bug Depends on: | |||
| Bug Blocks: | 283311 | ||
Ian Grunert
On Windows - if a class has a 'dllexport' attribute, all it's members get 'dllexport'-ed by default. Adding the 'dllexport' attribute to a member of that class generates an error:
attribute 'dllexport' cannot be applied to member of 'dllexport' class
This problem means using WTF_MAKE_TZONE_OR_ISO_ALLOCATED_EXPORT on a WEBCORE_EXPORT class causes a compilation error on Windows when libpas is enabled.
To get around this, we can split WTF_MAKE_TZONE_OR_ISO_ALLOCATED_EXPORT and WTF_MAKE_TZONE_OR_ISO_ALLOCATED_EXPORT_IN_EXPORTED_CLASS, so WTF_MAKE_TZONE_OR_ISO_ALLOCATED_EXPORT_IN_EXPORTED_CLASS can be made into WTF_NOEXPORT on Windows.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ian Grunert
Pull request: https://github.com/WebKit/WebKit/pull/41773
EWS
Committed 291811@main (a4ec5bc90ef5): <https://commits.webkit.org/291811@main>
Reviewed commits have been landed. Closing PR #41773 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/146515863>