Bug 288893
| Summary: | [Win] Remove USE(CF) || USE(GLIB) blocks from GC code paths | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ian Grunert <ian.grunert> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | PC | ||
| OS: | Windows 11 | ||
Ian Grunert
In the past JSRunLoopTimer and garbage collector timers were implemented with custom CF / GLib code. As a result there were some USE(CF) || USE(GLIB) blocks in GCController::garbageCollectSoon(), GCController::garbageCollectNowIfNotDoneRecently(), and WorkerGlobalScope::deleteJSCodeAndGC().
However in bug 214102 / https://commits.webkit.org/r264696 the JSRunLoopTimer (previously named HeapTimer) switched to use WTF::RunLoop rather than custom CF code. As it's now using that cross-platform abstraction, USE(CF) || USE(GLIB) blocks are no longer necessary, allowing Windows to use the same code paths.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ian Grunert
Pull request: https://github.com/WebKit/WebKit/pull/41688
EWS
Committed 291439@main (62c5f85e65e6): <https://commits.webkit.org/291439@main>
Reviewed commits have been landed. Closing PR #41688 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/145924769>