RESOLVED FIXED288893
[Win] Remove USE(CF) || USE(GLIB) blocks from GC code paths 
https://bugs.webkit.org/show_bug.cgi?id=288893
Summary [Win] Remove USE(CF) || USE(GLIB) blocks from GC code paths
Ian Grunert
Reported 2025-02-28 17:43:53 PST
In the past JSRunLoopTimer and garbage collector timers were implemented with custom CF / GLib code. As a result there were some USE(CF) || USE(GLIB) blocks in GCController::garbageCollectSoon(), GCController::garbageCollectNowIfNotDoneRecently(), and WorkerGlobalScope::deleteJSCodeAndGC(). However in bug 214102 / https://commits.webkit.org/r264696 the JSRunLoopTimer (previously named HeapTimer) switched to use WTF::RunLoop rather than custom CF code. As it's now using that cross-platform abstraction, USE(CF) || USE(GLIB) blocks are no longer necessary, allowing Windows to use the same code paths.
Attachments
Add attachment proposed patch, testcase, etc.
Ian Grunert
Comment 1 2025-02-28 17:51:49 PST
Pull request: https://github.com/WebKit/WebKit/pull/41688
EWS
Comment 2 2025-03-01 08:43:52 PST
Committed 291439@main (62c5f85e65e6): <https://commits.webkit.org/291439@main> Reviewed commits have been landed. Closing PR #41688 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2025-03-01 08:44:12 PST
<rdar://problem/145924769>
Note You need to log in before you can comment on or make changes to this bug.