Bug 288691
| Summary: | Use Platform.h defines from Swift code | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Elliott Williams <emw> |
| Component: | Tools / Tests | Assignee: | Elliott Williams <emw> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | richard_robinson2, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 289209 | ||
| Bug Blocks: | |||
Elliott Williams
As we write more Swift code in Apple's codebase, we wind up duplicating the platform and feature availability logic in <wtf/Platform.h> in Xcode build settings. We have to conditionally set `SWIFT_ACTIVE_COMPILATION_CONDITIONS` in xcconfigs to achieve the same behavior, and it's easy for these definitions to get out of sync. This bug tracks making Swift able to use platform definitions from their canonical location in WTF.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/145717488>
Elliott Williams
Pull request: https://github.com/WebKit/WebKit/pull/41495
EWS
Committed 291648@main (168c0aee29a2): <https://commits.webkit.org/291648@main>
Reviewed commits have been landed. Closing PR #41495 and removing active labels.
Elliott Williams
<rdar://problem/146335497>
Elliott Williams
Re-opening for pull request https://github.com/WebKit/WebKit/pull/41955
EWS
Committed 291661@main (8e711ebc97d4): <https://commits.webkit.org/291661@main>
Reviewed commits have been landed. Closing PR #41955 and removing active labels.
Elliott Williams
Reopened Bugzilla.
Revert "[Swift] Use Platform.h feature defines as compilation conditions", tracking revert in https://bugs.webkit.org/show_bug.cgi?id=289209.
Elliott Williams
Pull request: https://github.com/WebKit/WebKit/pull/41974
EWS
Committed 291794@main (dcebb661f447): <https://commits.webkit.org/291794@main>
Reviewed commits have been landed. Closing PR #41974 and removing active labels.
EWS
Committed 291803@main (b2137e4f8c2a): <https://commits.webkit.org/291803@main>
Reviewed commits have been landed. Closing PR #42104 and removing active labels.