Bug 288587
| Summary: | GPU process uses same map for all resources | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> |
| Component: | WebKit Process Model | Assignee: | Kimmo Kinnunen <kkinnunen> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | nham, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Kimmo Kinnunen
GPU process uses same map for all resources
This is a problem for
- performance: lookups are slower because the type is the best discriminator
- memory size: bigger maps reserve bigger overallocation
- type safety: code can mistake A for B if A and B are in the same map
- code structure: the key, RenderingResourceIdentifier, is making the code more obscure than having each type have its own identifier, similar to any other resource
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/145647088>
Kimmo Kinnunen
Pull request: https://github.com/WebKit/WebKit/pull/41393
EWS
Committed 291617@main (c8076268408d): <https://commits.webkit.org/291617@main>
Reviewed commits have been landed. Closing PR #41393 and removing active labels.