Bug 28848

Summary:

[V8] Inlined fast paths of V8DOMWrapper::convertNodeToV8Object and V8Proxy::createWrapperFromCache.

Product:

WebKit

Reporter:

Vitaly Repeshko <vitalyr>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	none
patch: removed unused include in V8Proxy.h	none

Vitaly Repeshko

Reported 2009-08-31 10:02:11 PDT

[V8] Inlined fast paths of V8DOMWrapper::convertNodeToV8Object and V8Proxy::createWrapperFromCache.

Attachments
patch (6.98 KB, patch) 2009-08-31 10:07 PDT, Vitaly Repeshko	no flags	Details Formatted Diff Diff
patch: removed unused include in V8Proxy.h (6.79 KB, patch) 2009-08-31 10:24 PDT, Vitaly Repeshko	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Vitaly Repeshko

Comment 1 2009-08-31 10:07:14 PDT

Created attachment 38818 [details] patch

Vitaly Repeshko

Comment 2 2009-08-31 10:24:40 PDT

Created attachment 38820 [details] patch: removed unused include in V8Proxy.h

Dimitri Glazkov (Google)

Comment 3 2009-08-31 11:20:56 PDT

Comment on attachment 38820 [details] patch: removed unused include in V8Proxy.h r=me.

Eric Seidel (no email)

Comment 4 2009-08-31 11:38:38 PDT

Comment on attachment 38820 [details] patch: removed unused include in V8Proxy.h Rejecting patch 38820 from commit-queue. This patch will require manual commit. Failed to run "['svn', 'commit', '-m', '2009-08-31 Vitaly Repeshko <vitalyr@chromium.org>\n\n Reviewed by Dimitri Glazkov.\n\n [V8] Inlined fast paths of V8DOMWrapper::convertNodeToV8Object and\n V8Proxy::createWrapperFromCache.\n https://bugs.webkit.org/show_bug.cgi?id=28848\n\n * bindings/v8/V8DOMWrapper.cpp:\n (WebCore::V8DOMWrapper::convertDocumentToV8Object): Special\n function for document wrapping.\n (WebCore::V8DOMWrapper::convertNewNodeToV8Object): Slow case of\n wrapping a new node.\n * bindings/v8/V8DOMWrapper.h:\n (WebCore::V8DOMWrapper::convertNodeToV8Object): Extracted fast\n path from V8DOMWrapper.cpp.\n * bindings/v8/V8Proxy.cpp:\n (WebCore::V8Proxy::createWrapperFromCacheSlowCase):\n * bindings/v8/V8Proxy.h:\n (WebCore::V8Proxy::createWrapperFromCache): Extracted fast path\n from V8Proxy.cpp.\n']" exit_code: 1 cwd: None

Adam Barth

Comment 5 2009-08-31 18:02:20 PDT

Comment on attachment 38820 [details] patch: removed unused include in V8Proxy.h Try cq again. Looks like a patch was landed during build / test.

Eric Seidel (no email)

Comment 6 2009-08-31 19:03:19 PDT

Comment on attachment 38820 [details] patch: removed unused include in V8Proxy.h Rejecting patch 38820 from commit-queue. This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1

Eric Seidel (no email)

Comment 7 2009-09-01 02:18:39 PDT

Comment on attachment 38820 [details] patch: removed unused include in V8Proxy.h fast/workers/dedicated-worker-lifecycle.html -> timed out I suspect it's another flakey test. :(

Eric Seidel (no email)

Comment 8 2009-09-01 02:19:53 PDT

I'll work on commit-queue error reporting next week, right now errors are kinda poor. :(

Eric Seidel (no email)

Comment 9 2009-09-01 03:05:46 PDT

Comment on attachment 38820 [details] patch: removed unused include in V8Proxy.h Clearing flags on attachment: 38820 Committed r47921: <http://trac.webkit.org/changeset/47921>

Eric Seidel (no email)

Comment 10 2009-09-01 03:05:50 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.