Bug 288478
| Summary: | REGRESSION(290957@main): Build broken with USE_GTK4=OFF and ENABLE_WK_WEB_EXTENSIONS=OFF | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> |
| Component: | Tools / Tests | Assignee: | Adrian Perez <aperez> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | ||
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 285379 | ||
| Bug Blocks: | |||
Adrian Perez
If either -DUSE_GTK4=OFF or -DENABLE_WK_WEB_EXTENSIONS=OFF are passed to CMake, the build fails
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adrian Perez
Even after a few (needed) local fixes, we can still get into this situation:
ld.lld: error: duplicate symbol: webkit_web_extension_get_type
>>> defined at WebKitWebExtension.cpp
>>> Source/WebKit/CMakeFiles/WebKit.dir/WebProcess/InjectedBundle/API/glib/WebKitWebExtension.cpp.o:(webkit_web_extension_get_type)
>>> defined at WebKitWebExtension.cpp
>>> Source/WebKit/CMakeFiles/WebKit.dir/UIProcess/API/glib/WebKitWebExtension.cpp.o:(.text.webkit_web_extension_get_type+0x0)
This means we cannot have WebExtensions support at all with !ENABLE(2022_GLIB_API)... unless we change the name of the newly added WebKitWebExtension to something else.
Alexey Proskuryakov
Is this just a dupe of bug 288484 at this point?
Adrian Perez
(In reply to Alexey Proskuryakov from comment #2)
> Is this just a dupe of bug 288484 at this point?
Yes, I intended to fix the issue first but it was getting complicated and decided instead to revert the patches that had landed on main. Let's close this as well.
*** This bug has been marked as a duplicate of bug 288484 ***