V8 binding of WebSocket

• Component: WebCore JavaScript
• Status: RESOLVED FIXED

[Fumitoshi Ukai]

V8 binding of WebSocket API.

[Fumitoshi Ukai]

Created attachment 38851 [details]
V8 Bindings for WebSocket API


---
 10 files changed, 318 insertions(+), 1 deletions(-)

[Adam Barth]

Comment on attachment 38851 [details]
V8 Bindings for WebSocket API

This looks good.  I presume we already have LayoutTests from the JSC implementation?

nit:  In WebKit-land, we use FIXME instead of TODO.

Also, is there a bug on file for Worker support for WebSockets?

[Eric Seidel (no email)]

Comment on attachment 38851 [details]
V8 Bindings for WebSocket API

Rejecting patch 38851 from commit-queue.  This patch will require manual commit.

['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1

[Eric Seidel (no email)]

Comment on attachment 38851 [details]
V8 Bindings for WebSocket API

Rejecting patch 38851 from commit-queue.  This patch will require manual commit.

['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1

[Adam Barth]

Comment on attachment 38851 [details]
V8 Bindings for WebSocket API

Clearing flags on attachment: 38851

Committed r47941: <http://trac.webkit.org/changeset/47941>

[Adam Barth]

All reviewed patches have been landed.  Closing bug.

[Eric Seidel (no email)]

media/video-source-add-src.html -> crashed

The commit-queue hit bug 28845.

[Eric Seidel (no email)]

Sorry.  commit-queue failed because a layout test got left around from a previously failed patch:
svg/dom/smil-methods.svg -> failed

This type of error is tracked by bug 28603.