| Summary: | ImageDecoderFoo.cpp contains lots of copy & pasted code and should be refactored | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Peter Kasting <pkasting> | ||||||
| Component: | Images | Assignee: | Peter Kasting <pkasting> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | yong.li.webkit | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 26467 | ||||||||
| Attachments: |
|
||||||||
|
Description
Peter Kasting
2009-08-27 14:24:10 PDT
Created attachment 38687 [details]
Prep work before moving functions into ImageDecoder.cpp
Comment on attachment 38687 [details]
Prep work before moving functions into ImageDecoder.cpp
LGTM.
Comment on attachment 38687 [details] Prep work before moving functions into ImageDecoder.cpp Landed in r47836, clearing flags. Created attachment 38696 [details]
Refactor
Yay for removing duplicate copies of code.
Comment on attachment 38696 [details]
Refactor
Why wouldn't we just move this into an RGBABuffer.cpp? This is definitely better than before, but we generally try to do one-class per file.
(In reply to comment #5) > (From update of attachment 38696 [details]) > Why wouldn't we just move this into an RGBABuffer.cpp? This is definitely > better than before, but we generally try to do one-class per file. Yes, my eventual plan is to move this into a different file, in a different folder, with a different name. |