Bug 28750

Summary: Add a Linux and Mac SQLite VFS for Chromium
Product: WebKit Reporter: Dumitru Daniliuc <dumi>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: agl, andersca, aroben, beidson, dglazkov, fishd, michaeln, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   
Attachments:
Description Flags
patch
dglazkov: review-
patch none

Dumitru Daniliuc
Reported 2009-08-26 13:16:00 PDT
We should add a Chromium-specific SQLite VFS for Linux and Mac (just like we did for Windows) to support HTML5 DBs on all 3 platforms.
Attachments
patch (17.43 KB, patch)
2009-08-26 15:24 PDT, Dumitru Daniliuc 		dglazkov: review-
DetailsFormatted DiffDiff
patch (17.32 KB, patch)
2009-08-28 12:56 PDT, Dumitru Daniliuc 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dumitru Daniliuc
Comment 1 2009-08-26 13:20:36 PDT
A significant part of the review was already done at http://codereview.chromium.org/173205/show.
Dumitru Daniliuc
Comment 2 2009-08-26 15:24:29 PDT
Created attachment 38640 [details] patch
Dimitri Glazkov (Google)
Comment 3 2009-08-28 12:34:52 PDT
Comment on attachment 38640 [details] patch > - // open databases using Chromium's VFS > + // open databases using the default VFS > + // in renderers, it should be Chromium's VFS; in the browser process it should be SQLite's default VFS > return sqlite3_open_v2(fileName.utf8().data(), database, > SQLITE_OPEN_READWRITE | SQLITE_OPEN_CREATE | SQLITE_OPEN_FULLMUTEX, > - "chromium_vfs"); > + NULL); 0 is WebKit style. Otherwise, LGTM.
Dumitru Daniliuc
Comment 4 2009-08-28 12:56:59 PDT
Created attachment 38747 [details] patch Replaced NULL with 0.
Dimitri Glazkov (Google)
Comment 5 2009-08-28 13:01:36 PDT
Comment on attachment 38747 [details] patch r=me.
Dimitri Glazkov (Google)
Comment 6 2009-08-28 13:26:40 PDT
Comment on attachment 38747 [details] patch It's a two-sided patch. Out the queue we go.
Ojan Vafai
Comment 7 2009-08-28 14:44:46 PDT
Comment on attachment 38747 [details] patch Clearing flags on attachment: 38747 Committed r47874: <http://trac.webkit.org/changeset/47874>
Ojan Vafai
Comment 8 2009-08-28 14:44:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.