Bug 28741

Summary:

[GTK] Out-of-srcdir build problem

Product:

WebKit

Reporter:

Priit Laes (IRC: plaes) <plaes>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
webkit-bug-28741-fix-out-of-srcdir-build.patch	none
webkit-bug-28741-fix-out-of-srcdir-build-v2.patch	xan.lopez: review+, xan.lopez: commit-queue-

Priit Laes (IRC: plaes)

Reported 2009-08-26 08:53:44 PDT

Doing an out-of-sourcedir build (builddir != srcdir) is not working correctly: [snip] GEN DerivedSources/webkitenumtypes.cpp echo "extern \"C\" {" > ./DerivedSources/webkitmarshal.cpp && \ @echo " GEN " stamp-webkitmarshal.cpp;/usr/bin/glib-genmarshal --prefix=webkit_marshal ../WebKit/gtk/webkitmarshal.list --body >> ./DerivedSources/webkitmarshal.cpp && echo '}' >> ./DerivedSources/webkitmarshal.cpp && \ echo timestamp > stamp-webkitmarshal.cpp /bin/sh: line 1: @echo: käsku ei ole GEN stamp-webkitmarshal.h Can't open WebKit/gtk/webkit/webkitversion.h: No such file or directory at /usr/bin/glib-mkenums line 281. GEN stamp-webkitenumtypes.h cd . && /bin/sh ./config.status autotoolsconfig.h Can't open WebKit/gtk/webkit/webkitversion.h: No such file or directory at /usr/bin/glib-mkenums line 281. [/snip] This is because WebKit/gtk/webkit/webkitversion.h is generated by configure and is placed into builddir, but mkenums script is looking for it in srcdir.

Attachments
webkit-bug-28741-fix-out-of-srcdir-build.patch (4.41 KB, patch) 2009-08-26 10:44 PDT, Priit Laes (IRC: plaes)	no flags	Details Formatted Diff Diff
webkit-bug-28741-fix-out-of-srcdir-build-v2.patch (5.51 KB, patch) 2009-08-26 23:42 PDT, Priit Laes (IRC: plaes)	xan.lopez: review+ xan.lopez: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Priit Laes (IRC: plaes)

Comment 1 2009-08-26 10:44:59 PDT

Created attachment 38621 [details] webkit-bug-28741-fix-out-of-srcdir-build.patch This fixes the issue, but cannot committed until glib-2.22 hits mainline (as glib-mkenums @basename@ syntax is available since 2.22)

Xan Lopez

Comment 2 2009-08-26 22:45:37 PDT

(In reply to comment #1) > Created an attachment (id=38621) [details] > webkit-bug-28741-fix-out-of-srcdir-build.patch > > This fixes the issue, but cannot committed until glib-2.22 hits mainline (as > glib-mkenums @basename@ syntax is available since 2.22) This looks reasonable to me if you add a requirement for glib >= 2.21.5 in our configure.ac (and mark the patch for review when you upload it!).

Priit Laes (IRC: plaes)

Comment 3 2009-08-26 23:42:39 PDT

Created attachment 38659 [details] webkit-bug-28741-fix-out-of-srcdir-build-v2.patch Bumped glib version check and also fixed problem seen when generating marshals..

Xan Lopez

Comment 4 2009-08-26 23:53:58 PDT

Comment on attachment 38659 [details] webkit-bug-28741-fix-out-of-srcdir-build-v2.patch Seems to work ok, thanks!

Xan Lopez

Comment 5 2009-08-26 23:57:45 PDT

Comment on attachment 38659 [details] webkit-bug-28741-fix-out-of-srcdir-build-v2.patch We need to update the bot before committing this, marking - in the commit-queue.

Xan Lopez

Comment 6 2009-08-27 00:49:55 PDT

Landed in r47811, closing.

Note You need to log in before you can comment on or make changes to this bug.