Bug 28740

Summary: Factor out summary bar from Resources panel to reuse it in Heap profile view
Product: WebKit Reporter: Mikhail Naganov <mnaganov>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: pfeldman, rik, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch
timothy: review-
Comment addressed. timothy: review+

Mikhail Naganov
Reported 2009-08-26 08:15:29 PDT
The iTunes-like summary bar is currently private in Resources panel. As we want to reuse it in Heap profile view, it needs to be factored out as a separate component.
Attachments
Proposed patch (32.34 KB, patch)
2009-08-26 08:20 PDT, Mikhail Naganov 		timothy: review-
DetailsFormatted DiffDiff
Comment addressed. (32.36 KB, patch)
2009-08-27 08:54 PDT, Mikhail Naganov 		timothy: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mikhail Naganov
Comment 1 2009-08-26 08:20:57 PDT
Created attachment 38614 [details] Proposed patch
Timothy Hatcher
Comment 2 2009-08-27 08:38:32 PDT
Comment on attachment 38614 [details] Proposed patch > + return this.calculator_; > + this.calculator_ = x; Our coding style uses prefix underscores for private members/functions. Looks good otherwise.
Mikhail Naganov
Comment 3 2009-08-27 08:54:29 PDT
Created attachment 38672 [details] Comment addressed.
Pavel Feldman
Comment 4 2009-08-27 09:10:28 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/WebCore.gypi M WebCore/WebCore.vcproj/WebCore.vcproj M WebCore/inspector/front-end/ResourcesPanel.js M WebCore/inspector/front-end/WebKit.qrc M WebCore/inspector/front-end/inspector.css M WebCore/inspector/front-end/inspector.html Committed r47822
Pavel Feldman
Comment 5 2009-08-27 09:35:46 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog A WebCore/inspector/front-end/SummaryBar.js Committed r47823
Note You need to log in before you can comment on or make changes to this bug.