Bug 28731

Summary:

Setting the volume of a media element has no effect if called too early

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

WebCore Misc.

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

simon.fraser

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

All

Attachments:

Description	Flags
proposed patch	simon.fraser: review+

Description Eric Carlson 2009-08-25 21:34:05 PDT

On OSX, setting the volume of an audio element before it has loaded metadata has no effect because MediaPlayerPrivate::setVolume() bails if metaDataAvailable() is false. This is unnecessary, it is safe to set the movie volume as soon as the movie exists.

Comment 1 Eric Carlson 2009-08-25 21:34:48 PDT

rdar://7170177

Comment 2 Eric Carlson 2009-08-25 21:56:33 PDT

Created attachment 38596 [details]
proposed patch

Comment 3 Eric Carlson 2009-08-25 22:14:09 PDT

http://trac.webkit.org/changeset/47771