Bug 287283
| Summary: | Test fail on Mac outside US/Pacific time zone | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Johannes Odland <johannes.odland> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ap, gsnedders, rik, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | Mac (Apple Silicon) | ||
| OS: | macOS 15 | ||
| Bug Depends on: | 227983 | ||
| Bug Blocks: | |||
Johannes Odland
Many layout tests fail on Mac configured without US/Pacific time zone:
Regressions: Unexpected text-only failures (31)
accessibility/datetime/input-datetime-local-label-value.html [ Failure ]
accessibility/datetime/input-time-label-value.html [ Failure ]
http/tests/inspector/network/har/har-page-aggressive-gc.html [ Failure ]
http/tests/inspector/network/har/har-page.html [ Failure ]
imported/w3c/web-platform-tests/IndexedDB/structured-clone.any.html?41-60 [ Failure ]
imported/w3c/web-platform-tests/IndexedDB/structured-clone.any.html?61-80 [ Failure ]
imported/w3c/web-platform-tests/IndexedDB/structured-clone.any.worker.html?41-60 [ Failure ]
imported/w3c/web-platform-tests/IndexedDB/structured-clone.any.worker.html?61-80 [ Failure ]
inspector/model/remote-object/date.html [ Failure ]
inspector/unit-tests/cookie.html [ Failure ]
js/date-timeClip-large-values.html [ Failure ]
storage/indexeddb/modern/date-basic-private.html [ Failure ]
storage/indexeddb/modern/date-basic.html [ Failure ]
storage/indexeddb/modern/get-keyrange-private.html [ Failure ]
storage/indexeddb/modern/get-keyrange.html [ Failure ]
storage/indexeddb/modern/idbobjectstore-delete-1-private.html [ Failure ]
storage/indexeddb/modern/idbobjectstore-delete-1.html [ Failure ]
WebKit/WebKitBuild/Release/layout-test-results/accessibility/datetime/input-datetime-local-label-value-actual.txt
@@ -2,22 +2,22 @@
datetime1:
PASS: datetime.title === 'AXTitle: Meeting time:'
-AXValue: Oct 21, 2024 at 3:45 PM
+AXValue: 21 Oct 2024 at 15:45
AXDateValue: 2024-10-21 15:45:59 +0000
datetime2:
PASS: datetime.title === 'AXTitle: Meeting time:'
-AXValue: Oct 21, 2024 at 3:45 PM
+AXValue: 21 Oct 2024 at 15:45
AXDateValue: 2024-10-21 15:45:59 +0000
datetime3:
PASS: datetime.title === 'AXTitle: Meeting time:'
-AXValue: Oct 21, 2024 at 3:45 PM
+AXValue: 21 Oct 2024 at 15:45
AXDateValue: 2024-10-21 15:45:59 +0000
datetime4:
PASS: datetime.title === 'AXTitle: '
-AXValue: Oct 21, 2024 at 3:45 PM
+AXValue: 21 Oct 2024 at 15:45
AXDateValue: 2024-10-21 15:45:59 +0000
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sam Sneddon [:gsnedders]
(In reply to Johannes Odland from comment #0)
> http/tests/inspector/network/har/har-page-aggressive-gc.html [ Failure ]
> http/tests/inspector/network/har/har-page.html [ Failure ]
These are: https://bugs.webkit.org/show_bug.cgi?id=227983
Other ports already try and workaround a bunch of this, by just always using America/Los_Angeles (or equivalent):
```
Tools/Scripts/run-javascriptcore-tests
644:$ENV{TZ}="US/Pacific"; # Some tests fail if the time zone is not set to US/Pacific (<https://webkit.org/b/136363>)
Tools/Scripts/run-jsc-stress-tests
3120:# Some tests fail if the time zone is not set to US/Pacific
3123:ENV["TZ"] = "US/Pacific";
Tools/Scripts/webkitpy/port/base.py
775: # FIXME: Some tests fail if the time zone is not set to US/Pacific (<https://webkit.org/b/186612>)
776: clean_env['TZ'] = 'US/Pacific'
Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp
1040: g_assert_cmpstr(WebViewTest::javascriptResultToCString(value), ==, "America/Los_Angeles");
Tools/TestWebKitAPI/glib/WebKitGLib/TestMain.cpp
140: g_setenv("TZ", "America/Los_Angeles", TRUE);
Tools/flatpak/flatpakutils.py
973: "TZ": "America/Los_Angeles",
```
Radar WebKit Bug Importer
<rdar://problem/144413932>
Sam Sneddon [:gsnedders]
(In reply to Sam Sneddon [:gsnedders] from comment #1)
> Other ports already try and workaround a bunch of this, by just always using
> America/Los_Angeles (or equivalent):
https://bugs.webkit.org/show_bug.cgi?id=294726 just added more here