Bug 287215
| Summary: | Try migrating webkitpy.benchmark_runner.http_server_driver.http_server.builtin_http_server to ThreadingHTTPServer | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Sneddon [:gsnedders] <gsnedders> |
| Component: | Tools / Tests | Assignee: | Sam Sneddon [:gsnedders] <gsnedders> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dewei_zhu, jbedard, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=287213 | ||
Sam Sneddon [:gsnedders]
Since Python 3.7, ThreadingHTTPServer is finally documented. Per its documentation:
> This is useful to handle web browsers pre-opening sockets, on which HTTPServer would wait indefinitely.
We've been using this in wptserve for long before it was documented with essentially no flakiness observed, so it seems highly likely to be a win here.
It may also resolve the bug described within bug 287213, though obviously the summary of the bug is recommending a specific solution there.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/144358027>
Sam Sneddon [:gsnedders]
Pull request: https://github.com/WebKit/WebKit/pull/40184
EWS
Committed 289986@main (f3615e97b23e): <https://commits.webkit.org/289986@main>
Reviewed commits have been landed. Closing PR #40184 and removing active labels.