Bug 28720

Summary:

[V8] Fix Canvas layout test failures in Chromium build.

Product:

WebKit

Reporter:

Jian Li <jianli>

Component:

WebKit Misc.

Assignee:

Jian Li <jianli>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, levin

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed Patch	levin: review+, jianli: commit-queue-

Description Jian Li 2009-08-25 15:22:55 PDT

Fix Canvas layout test failures in Chromium build. The previous fix r47757 does not handle the V8 object conversion correctly.

Comment 1 Jian Li 2009-08-25 15:26:49 PDT

Created attachment 38571 [details]
Proposed Patch

Comment 2 David Levin 2009-08-25 15:32:06 PDT

Comment on attachment 38571 [details]
Proposed Patch


> diff --git a/WebCore/bindings/v8/custom/V8DocumentCustom.cpp b/WebCore/bindings/v8/custom/V8DocumentCustom.cpp
> +        ASSERT(false);

Use ASSERT_NOT_REACHED();

>  } // namespace WebCore
> diff --git a/WebCore/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp b/WebCore/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp
> +        ASSERT(false);

Use ASSERT_NOT_REACHED();

Comment 3 Jian Li 2009-08-25 15:39:41 PDT

Committed as http://trac.webkit.org/changeset/47758