Bug 287162
| Summary: | [GStreamer] Refactor away MediaPlayerPrivateGStreamer::m_isPausedByViewport | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Alicia Boya García <aboya> |
| Component: | WebKitGTK | Assignee: | Alicia Boya García <aboya> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Alicia Boya García
This is a follow-up of the cleanups discussed in
https://github.com/WebKit/WebKit/pull/39765.
This patch combines m_isPausedByViewport and m_invisiblePlayerState into
one single field and renames it to m_stateToRestoreWhenVisible. The
field is set to VOID_PENDING when we're not paused by viewport.
Additionally, safeguards have been added to setVisibleInViewport() to
prevent the suspension code from accidentally running more than once.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alicia Boya García
Pull request: https://github.com/WebKit/WebKit/pull/40129
EWS
Committed 289997@main (bafa3f6bc15f): <https://commits.webkit.org/289997@main>
Reviewed commits have been landed. Closing PR #40129 and removing active labels.