Bug 28713

Summary: PLATFORM(CFNETWORK) should be USE(CFNETWORK).
Product: WebKit Reporter: David Levin <levin>
Component: WebKit Misc.Assignee: David Levin <levin>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
Proposed fix.
eric: review+, eric: commit-queue-
Proposed fix. aroben: review+

David Levin
Reported 2009-08-25 09:49:37 PDT
http://trac.webkit.org/changeset/44267 did this in WebKit/win/WebError.cpp http://trac.webkit.org/changeset/45505 did this in WebKitTools/DumpRenderTree/win/DumpRenderTree.cpp
Attachments
Proposed fix. (2.84 KB, patch)
2009-08-25 09:53 PDT, David Levin 		eric: review+
eric: commit-queue-
DetailsFormatted DiffDiff
Proposed fix. (4.00 KB, patch)
2009-08-25 10:58 PDT, David Levin 		aroben: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Levin
Comment 1 2009-08-25 09:53:56 PDT
Created attachment 38552 [details] Proposed fix.
Eric Seidel (no email)
Comment 2 2009-08-25 10:23:28 PDT
Looks fine to me. CCing adam so he sees this go by.
Eric Seidel (no email)
Comment 3 2009-08-25 10:23:53 PDT
Comment on attachment 38552 [details] Proposed fix. LGTM. You can cq+ this yourself if you like.
Adam Roben (:aroben)
Comment 4 2009-08-25 10:28:42 PDT
Comment on attachment 38552 [details] Proposed fix. This looks good. Let's define WTF_PLATFORM_CFNETWORK to something that will cause a compiler error that explains the problem. Something like: #define WTF_PLATFORM_CFNETWORK USE_macro_should_be_used_with_CFNETWORK
David Levin
Comment 5 2009-08-25 10:58:03 PDT
Created attachment 38556 [details] Proposed fix.
Adam Roben (:aroben)
Comment 6 2009-08-25 11:24:04 PDT
Comment on attachment 38556 [details] Proposed fix. r=me
David Levin
Comment 7 2009-08-25 11:30:28 PDT
Committed as https://bugs.webkit.org/show_bug.cgi?id=28713
Note You need to log in before you can comment on or make changes to this bug.