Bug 287079
| Summary: | [JSC] Use C++ concepts to constrain `Delegate` type parameter for `Yarr::parse()` | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tetsuharu Ohzeki [UTC+9] <tetsuharu.ohzeki> |
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Tetsuharu Ohzeki [UTC+9]
`Yarr::parse()` has `Delegate` typeparameter but its constraint is documented as a comment in our code, not like an abstract class.
- https://github.com/WebKit/WebKit/blob/446d00e44d23eba2d8c1c1c92bf0171472dee385/Source/JavaScriptCore/yarr/YarrParser.h#L2109-L2195
- https://github.com/WebKit/WebKit/blob/446d00e44d23eba2d8c1c1c92bf0171472dee385/Source/JavaScriptCore/yarr/YarrPattern.cpp#L1002
- https://github.com/WebKit/WebKit/blob/446d00e44d23eba2d8c1c1c92bf0171472dee385/Source/JavaScriptCore/yarr/YarrSyntaxChecker.cpp#L34-L59
We can use a concepts for its constraint, I think.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Tetsuharu Ohzeki [UTC+9]
Pull request: https://github.com/WebKit/WebKit/pull/40045
Radar WebKit Bug Importer
<rdar://problem/144681864>
EWS
Committed 290702@main (be68a2f3be90): <https://commits.webkit.org/290702@main>
Reviewed commits have been landed. Closing PR #40045 and removing active labels.