Bug 286964
| Summary: | snappedSelectionRect() has redundant parameters | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | fantasai <fantasai.bugs> |
| Component: | Layout and Rendering | Assignee: | fantasai <fantasai.bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
fantasai
In LayoutRect snappedSelectionRect(const LayoutRect& selectionRect, float logicalRight, float selectionTop, float selectionHeight, bool isHorizontal) we are effectively passing the selectionTop and selectionHeight parameters twice: once inside the selectionRect, and a second time as independent float values. We should just pass them once.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/144117546>
fantasai
Pull request: https://github.com/WebKit/WebKit/pull/39940
EWS
Committed 289768@main (43e213f4cdb0): <https://commits.webkit.org/289768@main>
Reviewed commits have been landed. Closing PR #39940 and removing active labels.
EWS
Committed 289651.115@safari-7621-branch (72390b9d0e97): <https://commits.webkit.org/289651.115@safari-7621-branch>
Reviewed commits have been landed. Closing PR #2598 and removing active labels.